Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it build with ghc-9.10 #599

Merged
merged 5 commits into from
Aug 5, 2024
Merged

Make it build with ghc-9.10 #599

merged 5 commits into from
Aug 5, 2024

Conversation

erikd
Copy link
Contributor

@erikd erikd commented Jul 29, 2024 •
edited
Loading

Changelog

- description: |
    Support ghc-9.10
# uncomment types applicable to the change:
  type:
  - maintenance    # not directly related to the code

Context

How to trust this PR

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@erikd erikd mentioned this pull request Jul 29, 2024
Closed
Jimbo4350
Jimbo4350 approved these changes Jul 29, 2024
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, devx will need to sort out CI.

carbolymer
carbolymer requested changes Jul 29, 2024
View reviewed changes
cardano-api/cardano-api.cabal Outdated Show resolved Hide resolved
@erikd erikd force-pushed the erikd/ghc-9.10 branch 2 times, most recently from e85a6f3 to 42780e2 Compare July 30, 2024 07:19
carbolymer
carbolymer approved these changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@carbolymer carbolymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erikd erikd force-pushed the erikd/ghc-9.10 branch 2 times, most recently from 1ea5e68 to 86c5ea4 Compare July 31, 2024 22:46
@erikd erikd mentioned this pull request Aug 2, 2024
Merged
3 tasks
@erikd
Make it build with ghc-9.10
7cccd30 
This also bumps the supported version of plutus-ledger-api.
@erikd
CI: Add ghc-9.10 to the build matrix
813cfb9
@erikd
Nix updates
660c333
@erikd erikd added this pull request to the merge queue Aug 5, 2024
Merged via the queue into main with commit 3d000e0 Aug 5, 2024
27 checks passed
@erikd erikd deleted the erikd/ghc-9.10 branch August 5, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@carbolymer carbolymer carbolymer approved these changes

@newhoggy newhoggy Awaiting requested review from newhoggy

@smelc smelc Awaiting requested review from smelc

@palas palas Awaiting requested review from palas

@dcoutts dcoutts Awaiting requested review from dcoutts

@kevinhammond kevinhammond Awaiting requested review from kevinhammond

@CarlosLopezDeLara CarlosLopezDeLara Awaiting requested review from CarlosLopezDeLara

@disassembler disassembler Awaiting requested review from disassembler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erikd @carbolymer @Jimbo4350 @hamishmack